-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify downloading multiple browsers #5743
Comments
I suggest to add a script to download an additional browser after the first |
We have to do this same hack in our CI too and I agree it would be nicer to not do this. I like the idea of the install script supporting a list of browsers. WDYT @mathiasbynens ? |
The plan is for |
npm install puppeteer This will install puppeteer and download chromium by default. cd node_modules/puppeteer
PUPPETEER_PRODUCT=firefox node install.js This will download firefox. |
I my opinion, browsers should be separate packages and no browser should be installed by default. That way one could install one, many or all browsers supported by Puppeteer. It would also solve the issue with browser versions. One might want to install the latest version, others an exact version they have tested with their app. |
We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days. |
We are closing this issue. If the issue still persists in the latest version of Puppeteer, please reopen the issue and update the description. We will try our best to accomodate it! |
I'm introducing Puppeteer for Mozilla's PDF.js project in mozilla/pdf.js#11807. One can use the
PUPPETEER_PRODUCT
environment variable to control which browser is downloaded, butnpm install
will always install either Chrome or Firefox. Is it possible to change this so that, for example,PUPPETEER_PRODUCT
accepts a comma-separated list instead?Now we install Puppeteer, which downloads Chrome, and have a separate post-install step that re-runs the Puppeteer installation script with
PUPPETEER_PRODUCT=firefox
to download Firefox too. This feels hacky.The text was updated successfully, but these errors were encountered: