Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update protocol.d.ts #5760

Merged
merged 1 commit into from Apr 28, 2020
Merged

chore: update protocol.d.ts #5760

merged 1 commit into from Apr 28, 2020

Conversation

jackfranklin
Copy link
Collaborator

@jackfranklin jackfranklin commented Apr 28, 2020

The result of npm run update-protocol-d-ts

@mathiasbynens mathiasbynens changed the title chore: Update protocol.d.ts chore: update protocol.d.ts Apr 28, 2020
@mathiasbynens
Copy link
Member

Should we enforce this on prepublish (or pre-commit, with git hooks)?

@jackfranklin
Copy link
Collaborator Author

Should we enforce this on prepublish (or pre-commit, with git hooks)?

Yeah, I was just thinking similar. Maybe a CI task that runs the generator and compares ? And errors if they are different?

My thinking of it being on CI is then people don't pay the cost on every commit. WDYT?

@jackfranklin
Copy link
Collaborator Author

@mathiasbynens I'm going to merge this as it's blocking my work on a TS migration but let me know what your thoughts are on how best to enforce this.

@jackfranklin jackfranklin merged commit e03113e into master Apr 28, 2020
@jackfranklin jackfranklin deleted the update-protocol-d-ts branch April 28, 2020 10:31
@mathiasbynens
Copy link
Member

My thinking of it being on CI is then people don't pay the cost on every commit. WDYT?

SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants