chore: enforce src/protocol.d.ts is in sync #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On CI we run `npm run compare-protocol-d-ts` which checks that the file on disk is up to date with the protocol we fetch from the browser.
jackfranklin
force-pushed
the
enforce-protocol-up-to-date
branch
from
1a0296b
to
fd691dd
Compare
| }); | ||
|
|
||
| const protocolOutputPath = path.join(__dirname, '..', '..', 'src', 'protocol.d.ts'); |
There was a problem hiding this comment.
Readability:
Suggested change
| const protocolOutputPath = path.join(__dirname, '..', '..', 'src', 'protocol.d.ts'); | |
| const protocolOutputPath = path.join(__dirname, '../../src/protocol.d.ts'); |
There was a problem hiding this comment.
I'd rather leave this as is so it works should anyone run this on Windows.
There was a problem hiding this comment.
path.join normalizes, so it would still work on Windows. (I would not have suggested this change otherwise.)
Co-Authored-By: Mathias Bynens <mathias@qiwi.be>
mathiasbynens
added a commit
that referenced
this pull request
May 4, 2020
This addresses the feedback from #5762 (comment).
mathiasbynens
added a commit
that referenced
this pull request
May 5, 2020
This addresses the feedback from #5762 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CI we run
npm run compare-protocol-d-tswhich checks that the fileon disk is up to date with the protocol we fetch from the browser.