Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce naming of errors in catch blocks #5763

Merged
merged 1 commit into from Apr 28, 2020
Merged

chore: enforce naming of errors in catch blocks #5763

merged 1 commit into from Apr 28, 2020

Conversation

jackfranklin
Copy link
Collaborator

No description provided.

@jackfranklin
Copy link
Collaborator Author

@mathiasbynens as discussed in the review on Paul's PR :)

mathiasbynens
mathiasbynens approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO GOOD!

@mathiasbynens mathiasbynens merged commit 1ccfbcb into master Apr 28, 2020
@mathiasbynens mathiasbynens deleted the eslint-rules branch April 28, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackfranklin @mathiasbynens @googlebot