chore: Enforce array type styles in TypeScript #5765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enforces how we type arrays, e.g. choosing between: * `string[]` * `Array<string>` I've gone for the `array-simple` option [1] which enforces that: * primitive types and type references use `X[]` * complex types use `Array<X>` For example, we'd type an array of strings as `string[]`, but an array of a union type as `Array<SomeUnionType>`. [1]: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/array-type.md
mathiasbynens
approved these changes
Apr 28, 2020
|
I don't feel strongly either - the one I picked follows the Google TS style guide, but happy to change it if you feel strongly. It's easily changed in the future too (it's fixable by eslint) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enforces how we type arrays, e.g. choosing between:
string[]Array<string>I've gone for the
array-simpleoption 1 which enforces that:X[]Array<X>For example, we'd type an array of strings as
string[], but an arrayof a union type as
Array<SomeUnionType>.