Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): update per recent changes #5778

Merged
merged 2 commits into from Apr 30, 2020

Conversation

jackfranklin
Copy link
Collaborator

A few tidy ups and updates where I noticed some info was lacking / outdated.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@@ -158,19 +169,6 @@ Despite being named 'unit', these are integration tests, making sure public API
npm run unit
```

- To run tests in parallel, use `-j` flag:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not useful anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Mocha doesn't support this out of the box.

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question

@mathiasbynens mathiasbynens changed the title chore: update and tidy up CONTRIBUTING.md docs(contributing): update per recent changes Apr 30, 2020
@mathiasbynens mathiasbynens merged commit 5fb399d into master Apr 30, 2020
paullewis pushed a commit that referenced this pull request Apr 30, 2020
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
@mathiasbynens mathiasbynens deleted the contributing-tweaks branch June 30, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants