Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore page.userAgent tests #5781

Closed
mathiasbynens opened this issue Apr 30, 2020 · 2 comments
Closed

Restore page.userAgent tests #5781

mathiasbynens opened this issue Apr 30, 2020 · 2 comments
Assignees
@mjzffr

Comments

@mathiasbynens
Copy link
Member

#5780 disabled another page.userAgent test that appeared to flake in Firefox on the bots, e.g. here: https://travis-ci.com/github/puppeteer/puppeteer/jobs/325068079#L267

@mjzffr @whimboo Could you please take a look?
@mathiasbynens mathiasbynens mentioned this issue Apr 30, 2020
Merged
@whimboo
Copy link
Collaborator

whimboo commented May 14, 2020

@mathiasbynens can you give some links to such broken Travis CI jobs? We have a very low intermittent faiilure for the moment, but if that fails permanently something else is going wrong.

@mathiasbynens
Copy link
Member Author

The link in OP used to point to such an example, but I guess restarting the CI job cleared the faulty output :( I looked but now cannot quickly find any other examples. Let’s close this for now.

mathiasbynens added a commit that referenced this issue May 14, 2020
@mathiasbynens
chore: restore page.setUserAgent test
eb70831 
Ref. #5781.
@mathiasbynens mathiasbynens mentioned this issue May 14, 2020
Merged
jackfranklin pushed a commit that referenced this issue May 14, 2020
@mathiasbynens
chore: restore page.setUserAgent test (#5868)
b2552e4 
Ref. #5781.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjzffr mjzffr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mathiasbynens @whimboo @mjzffr