New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text highlight for Javascript on debugging section #5799
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please indent
README.md
Outdated
@@ -198,22 +198,28 @@ Puppeteer creates its own browser user profile which it **cleans up on every run | |||
displaying. Instead of launching in headless mode, launch a full version of | |||
the browser using `headless: false`: | |||
|
|||
const browser = await puppeteer.launch({headless: false}); | |||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the backticks for syntax highlighting sounds great!
However, these backticked blocks must still be indented with 4 spaces so that they become part of the list item, instead of interrupting the list. Could you please make these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation, fixed.
Set a highlighted text for a smooth read, following the same pattern as per the README.