Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve readability for path strings #5805

Merged
merged 1 commit into from May 5, 2020
Merged

chore: improve readability for path strings #5805

merged 1 commit into from May 5, 2020

Conversation

mathiasbynens
Copy link
Member

This addresses the feedback from #5762 (comment).

@jackfranklin
Copy link
Collaborator

I don't actually agree with this change - I prefer using join consistently rather than mixing both - but I don't feel strongly enough to block it. Just sharing my 2c :)

@mathiasbynens
Copy link
Member Author

Ack. join normalizes the resulting path to allow for exactly this kind of usage. IMHO we should make use of it, since the hardcoded path part is now readable and copy-pastable, which seems strictly better than that not being the case.

@mathiasbynens mathiasbynens merged commit eed7d94 into master May 5, 2020
@mathiasbynens mathiasbynens deleted the improve-readability branch May 5, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfranklin jackfranklin jackfranklin approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathiasbynens @jackfranklin @googlebot