Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Node.js 12 & 14 to CI #5821

Merged
merged 1 commit into from May 7, 2020
Merged

chore: add Node.js 12 & 14 to CI #5821

merged 1 commit into from May 7, 2020

Conversation

jackfranklin
Copy link
Collaborator

No description provided.

@jackfranklin
Copy link
Collaborator Author

@mathiasbynens I think we should think about if we want to stick with our current setup of running primarily on Node 10 or if we should bring the baseline up. I have no strong prefs as long as we cover all versions we care about :)

@mathiasbynens
Copy link
Member

@jackfranklin I feel the same way. It's important that we keep running the general tests on LTS, but it seems like a good idea to move up the base line to, say, the latest stable version of Node.js for the extra checks.

@mathiasbynens mathiasbynens changed the title chore: add Node 12 and Node 14 to CI chore: add Node.12 & 14 to CI May 7, 2020
@mathiasbynens mathiasbynens changed the title chore: add Node.12 & 14 to CI chore: add Node.js 12 & 14 to CI May 7, 2020
@jackfranklin jackfranklin merged commit 70340de into master May 7, 2020
@jackfranklin jackfranklin deleted the run-node-14-ci branch May 7, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants