Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier to the codebase. #5825

Merged
merged 4 commits into from May 7, 2020
Merged

Add Prettier to the codebase. #5825

merged 4 commits into from May 7, 2020

Conversation

jackfranklin
Copy link
Collaborator

@mathiasbynens as discussed. Recommend going by commit as the last commit is just the re-format, the first two do the setup. Happy to change any of the config.

I also took the opportunity to tidy the ESLint file and remove rules that Prettier will effectively enforce.

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved and automated formatting (finally we can have spaces between async and () again!) and a simpler eslint as well. Big fan of this patch! :) Thanks Jack

@mathiasbynens mathiasbynens merged commit 4fdb1e3 into master May 7, 2020
@mathiasbynens mathiasbynens deleted the add-prettier branch May 7, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants