chore: remove src/TaskQueue #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only place it's used is in `src/Page.ts` to have a chain of screenshot promises. Rather than initialize a task queue in `Browser` and pass it through a chain of constructors we instead move the class into `src/Page` and define it inline. In the future we might want to create a helpers folder to contain small utilities like that (`src/Page.ts` is already far too large) but I'm leaving that for a future PR. `TaskQueue` isn't documented in `api.md` so I don't think this is a breaking change. I updated the type of `screenshot()` to return `Promise<string | Buffer | void>` because if a promise rejects it's silently swallowed. I'd like to change this behaviour but one step at a time. This type only had to change as now we type the screenshot task queue correctly rather than using `any` which then exposed the incorrect `screenshot()` types.
mathiasbynens
approved these changes
May 7, 2020
dmitrysteblyuk
pushed a commit
to dmitrysteblyuk/puppeteer
that referenced
this pull request
Apr 6, 2021
This reverts commit 49ce659.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place it's used is in
src/Page.tsto have a chain ofscreenshot promises. Rather than initialize a task queue in
Browserand pass it through a chain of constructors we instead move the class
into
src/Pageand define it inline.In the future we might want to create a helpers folder to contain small
utilities like that (
src/Page.tsis already far too large) but I'mleaving that for a future PR.
TaskQueueisn't documented inapi.mdso I don't think this is abreaking change.
I updated the type of
screenshot()to returnPromise<string | Buffer | void>because if a promise rejects it's silently swallowed. I'd liketo change this behaviour but one step at a time. This type only had to
change as now we type the screenshot task queue correctly rather than
using
anywhich then exposed the incorrectscreenshot()types.