You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should migrate all the tests to TypeScript. This will let us test our TypeScript definitions as we use them to write Puppeteer tests. It will also unify the codebase and let us write all new tests in TypeScript. We'll get nicer type-checking and so on which will help when authoring tests.
I think we can do this in a few steps:
Rename each file to *.ts
For any files with few errors, fix them.
For any files with large errors, put a @ts-nocheck comment at the top of the file to disable the type checking in that file.
Ship this change, having done the work to have Mocha compile the TS before running the tests.
Go through each file that was @ts-nocheck'd and fix the errors.
The text was updated successfully, but these errors were encountered:
We should migrate all the tests to TypeScript. This will let us test our TypeScript definitions as we use them to write Puppeteer tests. It will also unify the codebase and let us write all new tests in TypeScript. We'll get nicer type-checking and so on which will help when authoring tests.
I think we can do this in a few steps:
*.ts
@ts-nocheck
comment at the top of the file to disable the type checking in that file.@ts-nocheck
'd and fix the errors.The text was updated successfully, but these errors were encountered: