Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to TypeScript #5830

Closed
jackfranklin opened this issue May 7, 2020 · 1 comment
Closed

Migrate tests to TypeScript #5830

jackfranklin opened this issue May 7, 2020 · 1 comment
Assignees

Comments

@jackfranklin
Copy link
Collaborator

We should migrate all the tests to TypeScript. This will let us test our TypeScript definitions as we use them to write Puppeteer tests. It will also unify the codebase and let us write all new tests in TypeScript. We'll get nicer type-checking and so on which will help when authoring tests.

I think we can do this in a few steps:

  1. Rename each file to *.ts
  2. For any files with few errors, fix them.
  3. For any files with large errors, put a @ts-nocheck comment at the top of the file to disable the type checking in that file.
  4. Ship this change, having done the work to have Mocha compile the TS before running the tests.
  5. Go through each file that was @ts-nocheck'd and fix the errors.
@jackfranklin
Copy link
Collaborator Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant