chore: extract BrowserRunner into its own module
#5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`src/Launcher.ts` is large and hard to work in. It has multiple objects defined in it: * ChromeLauncher * FirefoxLauncher * BrowserRunner * Launcher This change moves BrowserRunner into its own module. More refactorings like this will follow but this is the first step.
jackfranklin
commented
May 12, 2020
| const removeFolderAsync = helper.promisify(removeFolder); | ||
| const debugLauncher = debug('puppeteer:launcher'); | ||
|
|
||
| export class BrowserRunner { |
There was a problem hiding this comment.
the functionality and contents of this class has not changed, other than the private keyword on the instance properties.
mathiasbynens
approved these changes
May 12, 2020
|
@mathiasbynens you read my mind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/Launcher.tsis large and hard to work in. It has multiple objectsdefined in it:
This change moves BrowserRunner into its own module. More refactorings
like this will follow but this is the first step.