Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract ConsoleMessage and FileChooser into its own module #5856

Merged

Conversation

christian-bromann
Copy link
Contributor

To support @jackfranklin's recent efforts in splitting up classes into their own modules here is a patch to do this for ConsoleMessage and FileChooser. It also starts to extract types into a single module and define them as types instead of interfaces.

src/types.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@jackfranklin jackfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for helping out! :)

I'd like to think about interfaces vs types and pick one and probably put some of the types back into the modules that own them (see the other comment) but once that's done I think this LGTM!

@christian-bromann
Copy link
Contributor Author

Can we rerun 3173.3 Unit tests [with coverage]: Linux/Chromium, seems like a flake.

@jackfranklin
Copy link
Collaborator

@christian-bromann it's not a flake, it's because the references to these classes in src/api.ts are now invalid. Would you mind updating those please?

@jackfranklin jackfranklin merged commit 69c38fc into puppeteer:master May 13, 2020
@christian-bromann christian-bromann deleted the cb-splitting-up-files branch May 13, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants