Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add securityDetails.subjectAlternativeNames() #5628 #5881

Merged
merged 6 commits into from May 18, 2020

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented May 18, 2020

Fixes issue #5625 - Get the sanList array of the SSL Certificate

Rebased version of #5628

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: no label May 18, 2020
@mathiasbynens
Copy link
Member

Thanks @mtoma and thanks @OrKoN for tackling the rebase!

@mathiasbynens mathiasbynens merged this pull request into master May 18, 2020
@mathiasbynens mathiasbynens deleted the fix-issue-5625 branch May 18, 2020 10:58
mathiasbynens pushed a commit that referenced this pull request May 18, 2020
Co-authored-by: Michal TOMA <michaltoma2205@gmail.com>
Co-authored-by: Alex Rudenko <alexrudenko@chromium.org>

Fixes #5625. Closes #5628.
@mtoma
Copy link
Contributor

mtoma commented May 18, 2020

Thanks @OrKoN for the rebase, appreciated the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants