Edited diagram for increased readability on dark backgrounds for #a11y #5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SVG version of diagram
jackfranklin
approved these changes
Jun 1, 2020
mathiasbynens
approved these changes
Jun 2, 2020
jackfranklin
pushed a commit
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SVG version of diagram, and placed it and the redone PNG in a new
assetsfolder. API markdown doc updated with relative path to updated PNG. I didn't update the Google Drawings source link to the SVG, but would recommend doing so.Added white stroke or background to all items, as it was not possible to read diagram data while using a dark theme due to transparency and lack of contrast.
I've submitted a CLA tied to this username, BTW, but do not publicly list my email address.