Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching Firefox on Windows fails on CI #5955

Closed
jackfranklin opened this issue Jun 1, 2020 · 5 comments
Closed

Launching Firefox on Windows fails on CI #5955

jackfranklin opened this issue Jun 1, 2020 · 5 comments

Comments

@jackfranklin
Copy link
Collaborator

@whimboo @mjzffr we're seeing this test fail on Windows CI builds when launching FireFox: #5954

We initially disabled the test because our Windows CI was so flakey it was impossible to know if it was a genuine bug or not but it now does appear to be as our CI on Windows has been very stable until this test got re-enabled.

That PR above defers the test for another month, in the meantime would you mind having a look if you get a chance?

Thanks!

@jackfranklin
Copy link
Collaborator Author

Update: there's actually two tests causing Windows issues : https://github.com/puppeteer/puppeteer/pull/5954/files

Would you mind looking at both? Please shout if I can help :)

@mjzffr
Copy link
Contributor

mjzffr commented Jun 1, 2020

@jackfranklin The one in headful.spec.js is under describeChromeOnly so you should probably take a look. :)

@whimboo whimboo added the firefox label Jun 2, 2020
@whimboo
Copy link
Collaborator

whimboo commented Jun 2, 2020

@jackfranklin isn't that just a dupe of issue #5673?

@jackfranklin
Copy link
Collaborator Author

@jackfranklin The one in headful.spec.js is under describeChromeOnly so you should probably take a look. :)

🤦 thank you! I guess I'll take that one ;)

@jackfranklin
Copy link
Collaborator Author

@whimboo good point, thanks. I'll close this one and we can track in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants