Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(new): add TSDoc comments to Accessibility #5971

Merged
merged 8 commits into from
Jun 5, 2020

Conversation

jackfranklin
Copy link
Collaborator

No description provided.

* The Accessibility class provides methods for inspecting Chromium's
* accessibility tree. The accessibility tree is used by assistive technology
* such as {@link https://en.wikipedia.org/wiki/Screen_reader | screen readers} or
* {@link https://en.wikipedia.org/wiki/Switch_access | switches}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question (not a blocker): is there any way to use Markdown here instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not, this is the syntax they chose. I'd have preferred Markdown links too :(

@jackfranklin
Copy link
Collaborator Author

@mathiasbynens this is ready for a review 👍

I'm also working on a doc to document how to move docs into TSDoc and common "gotchas" or things to look out for which should be ready soon

@jackfranklin jackfranklin merged commit 0b3d52a into master Jun 5, 2020
@jackfranklin jackfranklin deleted the tsdoc/accessibility branch June 5, 2020 14:20
@mathiasbynens mathiasbynens changed the title feat(new-docs): add TSDoc comments to Accessibility docs(new): add TSDoc comments to Accessibility Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants