feat(new-docs): migrate Dialog documentation to TSDoc #5981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfranklin
commented
Jun 8, 2020
jackfranklin
changed the title
jackfranklin
commented
Jun 8, 2020
| @@ -738,11 +738,16 @@ export class Page extends EventEmitter { | |||
|
|
|||
| _onDialog(event: Protocol.Page.javascriptDialogOpeningPayload): void { | |||
| let dialogType = null; | |||
| if (event.type === 'alert') dialogType = Dialog.Type.Alert; | |||
There was a problem hiding this comment.
this Dialog.Type only existed for this method and was never documented. So I removed it to save having it (and therefore having to document it).
mathiasbynens
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.