Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix effect -> affect typos #5985

Merged
merged 1 commit into from Jun 23, 2020
Merged

Conversation

teferi
Copy link
Contributor

@teferi teferi commented Jun 8, 2020

This PR fixes several typos in docs, where 'effect' was used incorrectly. Instead of a noun 'effect' this PR uses verb 'affect' where appropriate.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please sign the CLA so we can merge this?

@mathiasbynens mathiasbynens changed the base branch from master to main June 15, 2020 14:37
@jackfranklin
Copy link
Collaborator

@teferi ping on the CLA so we can ship this :)

@teferi
Copy link
Contributor Author

teferi commented Jun 22, 2020

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@teferi
Copy link
Contributor Author

teferi commented Jun 22, 2020

@teferi ping on the CLA so we can ship this :)

done and done =)

@mathiasbynens mathiasbynens merged commit fdc6fda into puppeteer:main Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants