chore: create new debug module #6028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This debug module can be used in either Node or the browser. We'll use the `debug` module in Node land, but fallback to a simple `console.log` solution when in the browser in an attempt to keep our browser bundle size down.
jackfranklin
changed the title
debug.
src/Debug.ts
Outdated
| * ``` | ||
| */ | ||
| export const debug = (prefix: string): ((...args: unknown[]) => void) => { | ||
| const isNodeEnv = typeof document === 'undefined'; |
There was a problem hiding this comment.
nit: Since the result should not change we can do it just once, so let's hoist this check out of the debug export.
jackfranklin
force-pushed
the
debug-browser-version
branch
from
7b96b26
to
b11fdb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.