Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(new): add TSDoc comments to WebWorker #6029

Merged
merged 4 commits into from Jun 17, 2020

Conversation

AVGP
Copy link
Contributor

@AVGP AVGP commented Jun 16, 2020

No description provided.

src/WebWorker.ts Outdated Show resolved Hide resolved
src/WebWorker.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@jackfranklin jackfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AVGP thank you so much for this! Few minor tweaks then I think this is good to go 👍

@AVGP
Copy link
Contributor Author

AVGP commented Jun 17, 2020

@jackfranklin Thanks for the review! Slowly getting the hang of this :)

@jackfranklin
Copy link
Collaborator

@AVGP one small comment then I think we can ship this!

You need to also run npm run generate-docs and commit the diff.

@AVGP
Copy link
Contributor Author

AVGP commented Jun 17, 2020

@jackfranklin done :)

@jackfranklin jackfranklin self-requested a review June 17, 2020 15:25
@jackfranklin jackfranklin merged commit 44402b7 into puppeteer:main Jun 17, 2020
@mathiasbynens mathiasbynens changed the title feat(new-docs): add TSDoc comments to WebWorker docs(new): add TSDoc comments to WebWorker Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants