docs(new): add TSDoc comments to Puppeteer #6032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@AVGP this is looking good! Few tiny tweaks and then we can ship this I think. Thank you!
|
Looks like you also need to run Prettier to fix up the formatting (that's what is failing CI). |
|
Done, including the tslint-fix |
mathiasbynens
changed the title
|
@AVGP if you wouldn't mind dealing with the conflicts, then we can ship this! Or if you'd like me to do the conflicts work and ship it, also happy to. Thanks! |
|
@jackfranklin Done. Just needs a review :) |
added 2 commits
June 23, 2020 18:17
jackfranklin
approved these changes
Jun 24, 2020
jackfranklin
pushed a commit
that referenced
this pull request
Jun 24, 2020
jackfranklin
added a commit
that referenced
this pull request
Jun 24, 2020
mathiasbynens
pushed a commit
that referenced
this pull request
Jun 25, 2020
mathiasbynens
pushed a commit
that referenced
this pull request
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.