chore: create node directory for Node-only files
#6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
approved these changes
Jun 18, 2020
This is another step towards making Puppeteer agnostic of environment and being able to run in Node or a browser. The files in the `node` directory are ones that would only be needed in the Node build - e.g. the code that downloads and launches a local browser instance. The long term vision here is to have three folders: * node - Node only code * web - Web only code * common - code that is shared But rather than do that in one PR I'm going to split it up to make it easier to review and deal with.
jackfranklin
force-pushed
the
create-node-directory
branch
from
adac232
to
7bb2bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards making Puppeteer agnostic of environment
and being able to run in Node or a browser.
The files in the
nodedirectory are ones that would only be needed inthe Node build - e.g. the code that downloads and launches a local
browser instance.
The long term vision here is to have three folders:
But rather than do that in one PR I'm going to split it up to make it
easier to review and deal with.