chore: remove top level errors and DeviceDescriptors #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell these became irrelevant as of v1.15 which added `puppeteer.errors` and `puppeteer.devices [1]. This is a breaking change but one that's easily mitigated. We've said that we don't consider changes to our folder/file structure a breaking change, but we can't really do that if we have these two top level files that we've documented. [1]: e3abb0a#diff-522b24108d7446af4c59873472a90444
|
@mathiasbynens WDYT with regards to this being a breaking change? My hunch is that we should play it better safe than sorry here. |
|
@jackfranklin Version numbers are free. When in doubt, let's just bump another major version. 👍 |
mathiasbynens
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell these became irrelevant as of v1.15 which added
puppeteer.errorsand `puppeteer.devices 1. This is a breaking changebut one that's easily mitigated. We've said that we don't consider
changes to our folder/file structure a breaking change, but we can't
really do that if we have these two top level files that we've
documented.