chore: move index.js into src and TS-ify
#6049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was causing some infra issues when trying to migrate tests to TypeScript (that's WIP in another branch that I'll have up soon). It's unusual to have the entire src in TS except for the main file, which then reaches into the compiled `lib` directory for the files it needs. Much better is to move the entry point into TypeScript itself and update the `main` entry in our `package.json` to point to the compiled output. This also has the advantange of hooking up all the TS type defs that we are shipping and will make that process easier too, along with making it easier to port our tests to TypeScript.
jackfranklin
commented
Jun 19, 2020
mathiasbynens
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was causing some infra issues when trying to migrate tests to
TypeScript (that's WIP in another branch that I'll have up soon). It's
unusual to have the entire src in TS except for the main file, which
then reaches into the compiled
libdirectory for the files it needs.Much better is to move the entry point into TypeScript itself and update
the
mainentry in ourpackage.jsonto point to the compiled output.This also has the advantange of hooking up all the TS type defs that we
are shipping and will make that process easier too, along with making it
easier to port our tests to TypeScript.