chore(agnostic): migrate DOMWorld #6054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
changed the title
|
@mathisbynens @paullewis PTAL. I'm not sure if this is the best approach or not for this but it's the least friction way to make progress so I'm quite keen to do a first pass using this approach and see how that treats us. Equally welcome to other ideas too. A follow up PR will start to split out |
| * limitations under the License. | ||
| */ | ||
|
|
||
| export const isNode = typeof document === 'undefined'; |
There was a problem hiding this comment.
Not gonna lie, the 15 lines of legalese followed by nothing but this elegant one-liner made me chuckle
There was a problem hiding this comment.
This check fails with JSDOM (e.g. in jest)
mathiasbynens
approved these changes
Jun 19, 2020
paullewis
approved these changes
Jun 23, 2020
jackfranklin
force-pushed
the
agnostic-dom-world
branch
from
39dfa9b
to
132df98
Compare
DOMWorld only needs to use Node's `fs` module if you're adding a filepath as a script/style tag. We can detect this case and run the `require` inline such that in a browser this code won't execute.
jackfranklin
force-pushed
the
agnostic-dom-world
branch
from
132df98
to
c1380da
Compare
mathiasbynens
pushed a commit
that referenced
this pull request
Jun 25, 2020
DOMWorld only needs to use Node's `fs` module if you're adding a filepath as a script/style tag. We can detect this case and run the `require` inline such that in a browser this code won't execute.
Hypnosphi
reviewed
Jul 10, 2020
| * | ||
| * You can pass a URL, filepath or string of contents. Note that when running Puppeteer | ||
| * in a browser environment you cannot pass a filepath and should use either | ||
| * `url` or `content`. |
There was a problem hiding this comment.
I think it makes sense to mention this in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOMWorld only needs to use Node's
fsmodule if you're adding afilepath as a script/style tag. We can detect this case and run the
requireinline such that in a browser this code won't execute.