Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(new): migrate TimeoutError to TSDoc #6062

Merged
merged 2 commits into from Jun 22, 2020
Merged

docs(new): migrate TimeoutError to TSDoc #6062

merged 2 commits into from Jun 22, 2020

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jun 22, 2020

No description provided.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 22, 2020

@jackfranklin it looks like the tests fail? Did I do something wrong here?

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 22, 2020

It looks like CI is using api-documenter 7.8.13 and my local version after npm install is 7.8.12

@jackfranklin
Copy link
Collaborator

It looks like CI is using api-documenter 7.8.13 and my local version after npm install is 7.8.12

Ah, we should probably hard pin this dependency to make sure there are no output differences locally vs CI. I'll do that in a PR now and that should resolve this.

@jackfranklin
Copy link
Collaborator

#6063 should enable this to go green!

@OrKoN OrKoN merged commit 1cf3f06 into main Jun 22, 2020
@OrKoN OrKoN deleted the tsdoc-timeout-error branch June 22, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants