Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin TSDoc related dependencies #6063

Merged
merged 1 commit into from Jun 22, 2020
Merged

chore: pin TSDoc related dependencies #6063

merged 1 commit into from Jun 22, 2020

Conversation

jackfranklin
Copy link
Collaborator

Without the API-* dependencies pinned different versions may be
installed on local machines vs CI. One of the checks we do is to check
that the checked in docs matches what is generated on CI. Therefore we
need to ensure devs locally run the exact version that CI runs such that
they generate the same output. So in this case we pin to a particular
version of the dependencies.

Without the API-* dependencies pinned different versions may be
installed on local machines vs CI. One of the checks we do is to check
that the checked in docs matches what is generated on CI. Therefore we
need to ensure devs locally run the exact version that CI runs such that
they generate the same output. So in this case we pin to a particular
version of the dependencies.
@@ -59,8 +59,8 @@
"ws": "^7.2.3"
},
"devDependencies": {
"@microsoft/api-documenter": "^7.8.8",
"@microsoft/api-extractor": "^7.8.8",
"@microsoft/api-documenter": "7.8.14",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should package-lock.json get updated too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's gitignored so no. I'm not sure why it's gitignored but going to leave it be for now.

@jackfranklin jackfranklin merged commit ace31d6 into main Jun 22, 2020
@jackfranklin jackfranklin deleted the pin-docs-deps branch June 22, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants