chore: migrate tests to TypeScript. #6075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfranklin
commented
Jun 22, 2020
This CL migrates all the tests to TypeScript. The main benefits of this is that we start consuming our TypeScript definitions and therefore find errors in them. The act of migrating found some bugs in our definitions and now we can be sure to avoid them going forwards. You'll notice the addition of some `TODO`s in the code; I didn't want this CL to get any bigger than it already is but I intend to follow those up once this lands. It's mostly figuring out how to extend the `expect` types with our `toBeGolden` helpers and some other slight confusions with types that the tests exposed.
mathiasbynens
approved these changes
Jun 23, 2020
tsconfig.json
Outdated
| }, | ||
| "include": [ | ||
| "src" | ||
| "src", |
There was a problem hiding this comment.
This is invalid JSON, but I guess tsc doesn't care?
test/assets/input/textarea.html
Outdated
| @@ -8,8 +8,8 @@ | |||
| <script src='mouse-helper.js'></script> | |||
| <script> | |||
| window.result = ''; | |||
| let textarea = document.querySelector('textarea'); | |||
| window.textarea = document.querySelector('textarea'); | |||
There was a problem hiding this comment.
Might as well use globalThis here too, for consistency
test/assets/input/textarea.html
Outdated
| @@ -8,8 +8,8 @@ | |||
| <script src='mouse-helper.js'></script> | |||
| <script> | |||
| window.result = ''; | |||
There was a problem hiding this comment.
Suggested change
| window.result = ''; | |
| globalThis.result = ''; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL migrates all the tests to TypeScript. The main benefits of this
is that we start consuming our TypeScript definitions and therefore find
errors in them. The act of migrating found some bugs in our definitions
and now we can be sure to avoid them going forwards.
You'll notice the addition of some
TODOs in the code; I didn't wantthis CL to get any bigger than it already is but I intend to follow
those up once this lands. It's mostly figuring out how to extend the
expecttypes with ourtoBeGoldenhelpers and some other slightconfusions with types that the tests exposed.