Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emulateMedia in v5 #6077

Closed
jackfranklin opened this issue Jun 23, 2020 · 2 comments
Closed

Remove emulateMedia in v5 #6077

jackfranklin opened this issue Jun 23, 2020 · 2 comments

Comments

@jackfranklin
Copy link
Collaborator

The next release will also be a major version due to the removal of the puppeteer/DeviceDescriptors files. Given that, we could also remove emulateMedia, which has been deprecated a while? Especially as the fix is to swap to emulateMediaType.

@mathiasbynens WDYT?
@mathiasbynens
Copy link
Member

SGTM

@christian-bromann
Copy link
Contributor

This can be closed as it was fixed by #6084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mathiasbynens @jackfranklin @christian-bromann