chore: fix ESLint violation and lessen rule strictness #6081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullewis
reviewed
Jun 23, 2020
| @@ -100,6 +100,11 @@ module.exports = { | |||
| "@typescript-eslint/semi": 2, | |||
| "@typescript-eslint/no-empty-function": 0, | |||
| "@typescript-eslint/no-use-before-define": 0, | |||
| // We have to use any on some types so the warning isn't valuable. | |||
There was a problem hiding this comment.
Yeah :( Long term we'll use the TS compiler strictness options to get rid of this but these warnings are adding no value.
paullewis
reviewed
Jun 23, 2020
| @@ -67,7 +67,7 @@ describe('Emulation', () => { | |||
| function dispatchTouch() { | |||
| let fulfill; | |||
| const promise = new Promise((x) => (fulfill = x)); | |||
| window.ontouchstart = function (e) { | |||
| window.ontouchstart = () => { | |||
There was a problem hiding this comment.
the majority of the codebase + tests use arrow functions - this one stood out to me so I just swapped it out
paullewis
approved these changes
Jun 23, 2020
jackfranklin
force-pushed
the
eslint-fixes
branch
from
e5085ea
to
10dc654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.