Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to troubleshooting broken since main branch change #6082

Closed
Georgegriff opened this issue Jun 23, 2020 · 5 comments
Closed

Link to troubleshooting broken since main branch change #6082

Georgegriff opened this issue Jun 23, 2020 · 5 comments

Comments

@Georgegriff
Copy link

image

Steps to reproduce

Tell us about your environment:

  • Puppeteer version:
  • Platform / OS version:
  • URLs (if applicable):
  • Node.js version:

What steps will reproduce the problem?

Please include code that reproduces the issue.

What is the expected result?

What happens instead?

@mathiasbynens
Copy link
Member

Since this is already fixed in the source (

'TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md',
), this will be fixed with the next release. We could set up a master branch as a mirror of main until then, but I'd rather not, since it'd complicate PRs (people might still have an old checkout that sends PRs to master). Instead, let's just publish a patch release asap. @jackfranklin @hanselfmu @OrKoN WDYT?

@jackfranklin
Copy link
Collaborator

We need to be careful here not to publish main as is as there's breaking changes due to go out as v5. There's no reason not to publish v5 this week (the breaking changes are very minor).

Or we could branch from the v4 tag and ship 4.0.1 that just fixes this link. What do you prefer?

@mathiasbynens
Copy link
Member

I was thinking of branching from v4 and shipping v4.0.1, but if we can commit to publishing v5 this week let's do that instead.

@jackfranklin
Copy link
Collaborator

Thinking about it, if we want v5 to include our own type defs, we might be pushing it to rush that out this week with other things going on, so v4.0.1 is probably the safest option. No real need to rush a major release out.

@jackfranklin
Copy link
Collaborator

This is now fixed in v4.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants