-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to troubleshooting broken since main
branch change
#6082
Comments
Since this is already fixed in the source ( puppeteer/src/node/BrowserRunner.ts Line 227 in fdc6fda
master branch as a mirror of main until then, but I'd rather not, since it'd complicate PRs (people might still have an old checkout that sends PRs to master). Instead, let's just publish a patch release asap. @jackfranklin @hanselfmu @OrKoN WDYT?
|
We need to be careful here not to publish Or we could branch from the |
I was thinking of branching from v4 and shipping v4.0.1, but if we can commit to publishing v5 this week let's do that instead. |
Thinking about it, if we want v5 to include our own type defs, we might be pushing it to rush that out this week with other things going on, so v4.0.1 is probably the safest option. No real need to rush a major release out. |
This is now fixed in v4.0.1. |
Steps to reproduce
Tell us about your environment:
What steps will reproduce the problem?
Please include code that reproduces the issue.
What is the expected result?
What happens instead?
The text was updated successfully, but these errors were encountered: