docs(new): migrate HTTPResponse docs to TSDoc #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ok(): boolean { | ||
| // TODO: document === 0 case? |
There was a problem hiding this comment.
@mathiasbynens do you have any context to this case? I'm not sure why we'd have this.
There was a problem hiding this comment.
I don't know, but I would guess this is used for errors before we can even get an HTTP response + status code, e.g. certificate issues. Maybe @sigurdschneider knows?
jackfranklin
approved these changes
Jun 24, 2020
|
I'm going to merge this, and we can make another PR to address the status = 0 case. |
mathiasbynens
pushed a commit
that referenced
this pull request
Jun 25, 2020
Co-authored-by: Changhao Han <changhaohan@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.