Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): add TSDoc to ExecutionContext #6094

Merged
merged 1 commit into from Jun 24, 2020
Merged

chore(docs): add TSDoc to ExecutionContext #6094

merged 1 commit into from Jun 24, 2020

Conversation

jackfranklin
Copy link
Collaborator

No description provided.

hanselfmu
hanselfmu approved these changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@hanselfmu hanselfmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jackfranklin jackfranklin merged commit b850ac2 into main Jun 24, 2020
@jackfranklin jackfranklin deleted the tsdoc-execution-context branch June 24, 2020 15:11
mathiasbynens pushed a commit that referenced this pull request Jun 25, 2020
@jackfranklin @AVGP @mathiasbynens
docs(new): add TSDoc comments to Puppeteer (#6032) (#6094)
48c5a8e 
Co-authored-by: Martin Splitt <mr.avgp@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanselfmu hanselfmu hanselfmu approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jackfranklin @googlebot @hanselfmu @AVGP