Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(new): migrate Page.ts to TSDoc (part 0 / 2) #6104

Merged
merged 6 commits into from Jun 26, 2020
Merged

Conversation

hanselfmu
Copy link
Collaborator

I'm breaking down the entire migration into three parts. This is the first part.

/**
* Sets the page's geolocation.
*
* * @remarks Consider using {@link BrowserContext.overridePermissions} to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got an extra * here before @remarks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing! Removed it.

Copy link
Collaborator

@jackfranklin jackfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick, otherwise this looks great! Thank you :)

@hanselfmu hanselfmu merged commit adeffba into main Jun 26, 2020
@hanselfmu hanselfmu deleted the tsdoc-page-0 branch June 26, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants