feat(types): add types for page.$$eval
#6139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hanselfmu PTAL, thanks :) |
jackfranklin
force-pushed
the
eval-types-2
branch
from
020cbe2
to
5861e1d
Compare
hanselfmu
reviewed
Jul 3, 2020
| * {@link https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors | selector} | ||
| * to query for | ||
| * @param pageFunction - the function to be evaluated in the page context. |
There was a problem hiding this comment.
Will API Extractor report a warning here if we remove the - after pageFunction?
There was a problem hiding this comment.
yes, it needs there to be a - between the param name and the description
hanselfmu
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.