chore(docs): document HTTPRequest with TSDoc #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfranklin
commented
Jul 2, 2020
| // string values are uppercase. The Puppeteer docs explicitly say the | ||
| // potential values are all lower case, and the constructor takes the event | ||
| // type and calls toLowerCase() on it, so we can't reuse the type from the | ||
| // protocol.d.ts. Why do we lower case? |
There was a problem hiding this comment.
@mathiasbynens I don't suppose you have any insight here?
There was a problem hiding this comment.
I suppose for parity with other Puppeteer APIs? We don't really use uppercase string values anywhere.
hanselfmu
reviewed
Jul 3, 2020
hanselfmu
approved these changes
Jul 3, 2020
jackfranklin
force-pushed
the
document-http-request
branch
from
276e08f
to
6f6f3fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.