chore: use devtools-protocol package #6172
Conversation
|
This isn't ready for merging yet; I'd like to understand how the revision numbers of devtools-protocol work - there isn't an exact version for the current revision of Chromium that we support, for example. |
jackfranklin
force-pushed
the
use-devtools-protocol
branch
from
b2a420c
to
72a603c
Compare
| 'Method Page.deleteCookie() ...cookies', | ||
| 'Method Page.setCookie() ...cookies', | ||
| ]); | ||
| if (skipPropertyChecksOnMethods.has(source)) return; |
There was a problem hiding this comment.
I have no idea why this change suddenly causes this; I've manually checked that the new types are identical to the old types in all but name.
At this point the doclint tooling is a mystery to me and I'd rather hack around it as we're quite close to removing it.
package.json
Outdated
| @@ -47,6 +45,7 @@ | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "debug": "^4.1.0", | |||
| "devtools-protocol": "0.0.758979", | |||
There was a problem hiding this comment.
need to confirm which revision number we're using
jackfranklin
force-pushed
the
use-devtools-protocol
branch
from
23031bf
to
a97c94e
Compare
| console.log( | ||
| `Correct devtools-protocol version found (${bestRevisionFromNpm}).` | ||
| ); | ||
| process.exit(0); |
There was a problem hiding this comment.
@mathiasbynens particularly interested in getting some more eyes on this
jackfranklin
force-pushed
the
use-devtools-protocol
branch
from
a97c94e
to
7e511b1
Compare
| 'Method Page.deleteCookie() ...cookies', | ||
| 'Method Page.setCookie() ...cookies', | ||
| ]); | ||
| if (skipPropertyChecksOnMethods.has(source)) return; |
mathiasbynens
changed the title
jackfranklin
force-pushed
the
use-devtools-protocol
branch
from
400248d
to
d63dbef
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Rather than maintain our own protocol we can instead use the devtools-protocol package and pin it to the version of Chromium that Puppeteer is shipping with. The only changes are naming changes between the bespoke protocol that Puppeteer created and the devtools-protocol one.
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
jackfranklin
force-pushed
the
use-devtools-protocol
branch
from
53360e2
to
8438dd4
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Rather than maintain our own protocol we can instead use the devtools-protocol package and pin it to the version of Chromium that Puppeteer is shipping with.
The only changes are naming changes between the bespoke protocol that Puppeteer created and the devtools-protocol one.