chore: forbid importing src/common/Events.ts #6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is now deprecated and only used by the coverage tool and DocLint - these tools will be updated to not rely on it in the future. We now have events defined per class - e.g. all the events that `Page` can emit are defined in the `PageEmittedEvents` enum, and similar. We have to keep `Events.ts` around for the aforementioned tools, but don't want its usage creeping back into our source code.
OrKoN
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is now deprecated and only used by the coverage tool and
DocLint - these tools will be updated to not rely on it in the future.
We now have events defined per class - e.g. all the events that
Pagecan emit are defined in the
PageEmittedEventsenum, and similar. Wehave to keep
Events.tsaround for the aforementioned tools, but don'twant its usage creeping back into our source code.