Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose HTTPRequest class in public API #6194

Closed
sgrimm opened this issue Jul 9, 2020 · 3 comments
Closed

Expose HTTPRequest class in public API #6194

sgrimm opened this issue Jul 9, 2020 · 3 comments

Comments

@sgrimm
Copy link

sgrimm commented Jul 9, 2020

Release 3.2.0 renamed the Request class to HTTPRequest and the release notes say it's not a breaking change because the class isn't exposed directly.

But it's the documented type of several events: https://github.com/puppeteer/puppeteer/blob/e67a860eb093c46fc33a5d265137f392c767b69d/docs/api.md#class-httprequest

It should be exposed in the public API so application code can use the correct type in event handlers.

@jackfranklin
Copy link
Collaborator

We don't yet expose the types for anything on purpose - we're working on shipping types very soon: #6124 . We're also working on new docs (#6118) - a combination of those will help with regards to types.

@stale
Copy link

stale bot commented Jun 26, 2022

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@stale stale bot added the unconfirmed label Jun 26, 2022
@stale
Copy link

stale bot commented Jul 26, 2022

We are closing this issue. If the issue still persists in the latest version of Puppeteer, please reopen the issue and update the description. We will try our best to accomodate it!

@stale stale bot closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants