chore: enforce file extensions on imports #6202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfranklin
commented
Jul 10, 2020
| @@ -88,7 +89,8 @@ module.exports = { | |||
|
|
|||
| "no-restricted-imports": ["error", { | |||
| patterns: ["*Events"], | |||
| }] | |||
| }], | |||
| "import/extensions": ["error", "ignorePackages"] | |||
There was a problem hiding this comment.
we need to figure out how packages work for a browser ESM build - but that's a separate issue to this one. I'll have a PR/issue up describing our potential approach later :)
paullewis
approved these changes
Jul 10, 2020
TimvdLippe
suggested changes
Jul 10, 2020
To make our output agnostic it should include file extensions in the output, as per the ESM spec. It's a bit odd for Node packages but makes it easier to publish a browser build.
jackfranklin
force-pushed
the
enforce-file-extensions
branch
from
9902dd5
to
2539082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.