Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when firefox isn't installed #6223

Closed
LarsDenBakker opened this issue Jul 16, 2020 · 2 comments
Closed

Improve error handling when firefox isn't installed #6223

LarsDenBakker opened this issue Jul 16, 2020 · 2 comments

Comments

@LarsDenBakker
Copy link
Contributor

When you want to use puppeteer with firefox you need to install your dependencies using an extra environment variable. If you don't do this and try to use firefox, the error message you get it is

Error: Could not find browser revision latest. Run "npm install" or "yarn install" to download a browser binary.

I think we could improve this by explaining the user that they need to set up an environent variable in order to download firefox. I'm wrapping puppeteer as part of another tool, so users will have an even harder time figuring out how to solve this.

I can submit a PR if you think this is useful to add.

@christian-bromann
Copy link
Contributor

@LarsDenBakker do you think this got resolved with #6226 ?

@LarsDenBakker
Copy link
Contributor Author

Yes indeed. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants