Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better describe how to install Firefox Nightly with Puppeteer #6226

Merged
merged 3 commits into from Jul 16, 2020

Conversation

christian-bromann
Copy link
Contributor

It can be very confusing when someone installs Puppeteer and wants to run Firefox. This small patch enhances the docs to make this a bit more obvious.

refs #6224

src/node/Launcher.ts Outdated Show resolved Hide resolved
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion.
cc @mjzffr

@mathiasbynens mathiasbynens self-assigned this Jul 16, 2020
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
@mathiasbynens mathiasbynens merged commit 82645e8 into puppeteer:main Jul 16, 2020
@christian-bromann christian-bromann deleted the cb-ff-docs-support branch July 16, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants