chore: test Connection class in the browser #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullewis
approved these changes
Jul 23, 2020
test-browser/connection.spec.js
Outdated
| const connection = new Connection('fake-url', new EchoTransport()); | ||
|
|
||
| /** | ||
| * 1 here is the ID because pptr increments a counter from 0 for each |
There was a problem hiding this comment.
nit: That took me a couple of reads, just because you started with the number 1, I think!
There was a problem hiding this comment.
ah yeah this could be worded more clearly, thanks! I'll tweak.
This commit creates a test that runs in the browser and ensures that we can instantiate a pptr Connection with a fake transport and send/receive messages. Longer term I'd like to have tests that actually connect to a browser and send CDP messages but that needs some changes to web-test-runner which I'm going to speak to them about - the DevTools URL needs to be exposed some how for us to use and connect to.
jackfranklin
force-pushed
the
connection-test
branch
from
e8e0221
to
520f625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a test that runs in the browser and ensures that we
can instantiate a pptr Connection with a fake transport and send/receive
messages.
Longer term I'd like to have tests that actually connect to a browser
and send CDP messages but that needs some changes to web-test-runner
which I'm going to speak to them about - the DevTools URL needs to be
exposed some how for us to use and connect to.