Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Fixed broken link to "setuid sandbox" #6310

Merged
merged 1 commit into from Aug 10, 2020

Conversation

clayzermk1
Copy link
Contributor

Minor documentation fix.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@clayzermk1
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 5, 2020
@jackfranklin
Copy link
Collaborator

Thanks for this!

I noticed at the top of the new docs it says:

IMPORTANT NOTE: The Linux SUID sandbox is almost but not completely removed. See
https://bugs.chromium.org/p/chromium/issues/detail?id=598454 This page is mostly out-of-date.

I therefore wonder if we should just remove this stuff from our docs. @mathiasbynens wdyt?

@mathiasbynens mathiasbynens merged commit b4c1e45 into puppeteer:main Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants