fix(FirefoxLauncher): use wait-for-process option on Windows #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
--wait-for-process,puppeteer.launchreturns before Firefox is ready on Windows, so this should be part of the default Firefox arguments on that platform.On Windows, firefox.exe starts a "launcher process" that is responsible for configuring and starting the "real" browser process. Passing
--wait-for-processmakes that launcher process wait for the entire life of the browser process, and will also propagate the browser process's exit code as its own.Note that the test highlighted in #5673 is still expected to fail because
BrowserRunnerdoesn't track the right process on Windows, which breaks itsclosecallback.