fix: revise interesting/uninteresting classification for AXNodes #6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbay
force-pushed
the
revise-interesting-classification
branch
from
878f57e
to
42d8451
Compare
mathiasbynens
approved these changes
Aug 12, 2020
This sounds good. Until then, I like this smaller, incremental change, so LGTM. |
hanselfmu
reviewed
Aug 14, 2020
| @@ -264,11 +266,7 @@ class AXNode { | |||
| private _isPlainTextField(): boolean { | |||
| if (this._richlyEditable) return false; | |||
| if (this._editable) return true; | |||
| return ( | |||
| this._role === 'textbox' || | |||
| this._role === 'ComboBox' || | |||
There was a problem hiding this comment.
Out of curiosity, what was this 'ComboBox' role and why is it not relevant anymore?
There was a problem hiding this comment.
I'm definitely not very knowledgeable in the area, but from searching around I concluded that there is no such role in the spec. There is a combobox, but I'm not sure we want to categorize those as plain text fields? At least our tests don't want that. I think we should remove the ComboBox for now as it is confusing.
hanselfmu
reviewed
Aug 14, 2020
johanbay
force-pushed
the
revise-interesting-classification
branch
from
42d8451
to
880fd0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to the logic for determining if an AXNode is interesting.
We might want to consider skipping this logic altogether and simply rely on CDP's
ignoredproperty on AXNodes