Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge frame url and frame url fragment for getting full url #6398

Merged
merged 3 commits into from Sep 8, 2020

Conversation

bryanmlyr
Copy link
Contributor

This Pr :

  • Retrieve full url by adding url fragment to url when trying to call url function from a frame.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bryanmlyr
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@bryanmlyr bryanmlyr closed this Sep 7, 2020
@bryanmlyr bryanmlyr reopened this Sep 7, 2020
@bryanmlyr
Copy link
Contributor Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 7, 2020
@mathiasbynens
Copy link
Member

Thanks for the patch. Two requests:

  • In the commit message, please explain what problem this is fixing.
  • Please add a test

@bryanmlyr
Copy link
Contributor Author

Thanks for the patch. Two requests:

  • In the commit message, please explain what problem this is fixing.
  • Please add a test

Done 😄

@mathiasbynens mathiasbynens merged commit b6bbfd0 into puppeteer:main Sep 8, 2020
@@ -0,0 +1 @@
<iframe src='./frame.html&test=fragment'></iframe>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be ./frame.html?test=fragment or ./frame.html#fragment instead?
According to https://github.com/puppeteer/puppeteer/blob/main/new-docs/puppeteer.protocol.page.frame.urlfragment.md the fragment is #fragment and ?param=value is often referred to as query.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@campersau That's a good point. Happy to accept a PR that changes these names!

campersau added a commit to campersau/puppeteer that referenced this pull request Sep 14, 2020
by using an actual fragment

references puppeteer#6398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants